Add satellite and various projection types to geo subplots #5801

archmoj · 2021-07-05T21:23:34Z

Resolves #4781 by adding new projection types to geo subplots.

Here is the full list of types:

"airy",
"aitoff",
"albers",
"albers usa",
"august",
"azimuthal equal area",
"azimuthal equidistant",
"baker",
"bertin1953",
"boggs",
"bonne",
"bottomley",
"bromley",
"collignon",
"conic conformal",
"conic equal area",
"conic equidistant",
"craig",
"craster",
"cylindrical equal area",
"cylindrical stereographic",
"eckert1",
"eckert2",
"eckert3",
"eckert4",
"eckert5",
"eckert6",
"eisenlohr",
"equirectangular",
"fahey",
"foucaut",
"foucaut sinusoidal",
"ginzburg4",
"ginzburg5",
"ginzburg6",
"ginzburg8",
"ginzburg9",
"gnomonic",
"gringorten",
"gringorten quincuncial",
"guyou",
"hammer",
"hill",
"homolosine",
"hufnagel",
"hyperelliptical",
"kavrayskiy7",
"lagrange",
"larrivee",
"laskowski",
"loximuthal",
"mercator",
"miller",
"mollweide",
"mt flat polar parabolic",
"mt flat polar quartic",
"mt flat polar sinusoidal",
"natural earth",
"natural earth1",
"natural earth2",
"nell hammer",
"nicolosi",
"orthographic",
"patterson",
"peirce quincuncial",
"polyconic",
"rectangular polyconic",
"robinson",
"satellite",
"sinu mollweide",
"sinusoidal",
"stereographic",
"times",
"transverse mercator",
"van der grinten",
"van der grinten2",
"van der grinten3",
"van der grinten4",
"wagner4",
"wagner6",
"wiechel",
"winkel tripel",
"winkel3"

@plotly/plotly_js

cc: @disberd

src/plots/geo/constants.js

nicolaskruchten · 2021-07-07T19:00:15Z

LGTM! ✨

alexcjohnson · 2021-07-07T21:03:52Z

src/plots/geo/geo.js

-        constants.lonaxisSpan[projType] / 2 :
-        null;
+    var clipAngle =
+        projType === 'satellite' ? Math.acos(1 / projection.distance()) * 180 / Math.PI :


Where does projection.distance() come from? Is that linked to the projection.scale attribute? I imagine users of the satellite would want to be able to fix the satellite's location (height and center lat/lon) and still zoom and pan - to match up with a specific image taken by a satellite. Is that possible as it stands?

The distance and tilt options are now implemented for satellite by d102a47.

alexcjohnson · 2021-07-07T21:04:20Z

src/plots/geo/constants.js


    'airy': 'airy',
    // 'albers': 'albers',
-    'armadillo': 'armadillo',
+    // 'armadillo': 'armadillo',


Is there a pattern to the ones we're still omitting?

Some of these are now enabled by eb30073.
Let me see if I could easily fix the clipping issue for some other remaining ones...

Most of the remaining ones are interrupted-projections and polyhedral-projections as well as two-point projections , require extra work and attributes and we could say it is outside the scope of this PR.

test/plot-schema.json

archmoj · 2021-07-08T20:23:46Z

@plotly/plotly_js and @disberd this PR is now reviewable and if you could play with it : )

alexcjohnson · 2021-07-08T22:16:32Z

test/image/mocks/canada_geo_projections.json

+      "fitbounds": "locations",
+      "projection": {
+        "rotation": {"lat": 45},
+        "type": "mercator"


strange to think of this as a mercator projection when it has a rotation... can we omit projection.rotation from this mock, and let the projection do its own thing? Hopefully that will automatically rotate those projections that use rotation to fit their contents, but will use center for mercator and others like it. That would allow this mocks to function as more than just "these projections all work zoomed in", but also "here's the kind of map you can expect from each projection"

Hmm... geo_fitbounds-locations basically tests just that for Australia.
OK please see 77f0367 and then 8e352e2.
Keeping rotation for those three projections can simply help illustrate that the projection could actually be used with Canada.

Keeping rotation for those three projections can simply help illustrate that the projection could actually be used with Canada.

I'd argue that this shows these projections may not be optimizing the correct variables when doing fitbounds - but if there's no obvious fix for that we can leave it. Thanks for dropping all the other rotations.

alexcjohnson

💃 that's a whole lot of projections 😲

archmoj added 6 commits July 5, 2021 11:24

produce geo_fitbounds-locations using a script

e3b0ca3

sort projection names in geo_fitbounds-locations

10c402f

show ocean on non-usa projections in geo_fitbounds-locations

57da6f7

add several new projection types to the API

0fc177b

create mock for various projection types

3da8db5

remove geo mock script

efd9b14

archmoj added feature something new status: reviewable labels Jul 5, 2021

archmoj added this to the NEXT milestone Jul 5, 2021

archmoj mentioned this pull request Jul 5, 2021

Satellite geo projection #4781

Closed

archmoj commented Jul 6, 2021

View reviewed changes

src/plots/geo/constants.js Outdated Show resolved Hide resolved

archmoj added the status: has TODOs label Jul 6, 2021

archmoj added 3 commits July 6, 2021 18:43

adjust satellite clip angle based on distance

26e4562

add new image test

a121c49

do not add gilbert projection

645a10a

archmoj removed the status: has TODOs label Jul 7, 2021

archmoj added 3 commits July 7, 2021 11:27

Merge remote-tracking branch 'origin/master' into new-geo-projections

05cc7c4

draft log for PR 5801

d1ae4c9

reflect schema changes

0840127

archmoj requested review from alexcjohnson and nicolaskruchten July 7, 2021 16:37

alexcjohnson reviewed Jul 7, 2021

View reviewed changes

test/plot-schema.json Show resolved Hide resolved

archmoj added 4 commits July 8, 2021 10:40

implement tilt and distance for satellite projection

d102a47

add some other projection types

eb30073

move albers-usa to the end i.e. to make room for global albers

2b74d71

add albers projection

bf839d3

archmoj changed the title ~~Add satellite and other new projection types to geo subplots~~ Add satellite and various other projection types to geo subplots Jul 8, 2021

archmoj changed the title ~~Add satellite and various other projection types to geo subplots~~ Add satellite and various projection types to geo subplots Jul 8, 2021

sort geo projection types

5fd3428

archmoj requested a review from alexcjohnson July 8, 2021 20:21

alexcjohnson reviewed Jul 8, 2021

View reviewed changes

archmoj mentioned this pull request Jul 8, 2021

Sort object key values in schema #5813

Merged

archmoj added 2 commits July 9, 2021 09:13

drop rotations in canada_geo_projections

77f0367

add rotations for only 3 types in canada_geo_projections

8e352e2

alexcjohnson approved these changes Jul 9, 2021

View reviewed changes

archmoj merged commit 01e25e7 into master Jul 9, 2021

archmoj deleted the new-geo-projections branch July 9, 2021 15:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add satellite and various projection types to geo subplots #5801

Add satellite and various projection types to geo subplots #5801

archmoj commented Jul 5, 2021 •

edited

Loading

nicolaskruchten commented Jul 7, 2021

alexcjohnson Jul 7, 2021

archmoj Jul 8, 2021

alexcjohnson Jul 7, 2021

archmoj Jul 8, 2021

archmoj Jul 8, 2021

archmoj commented Jul 8, 2021

alexcjohnson Jul 8, 2021

archmoj Jul 9, 2021

alexcjohnson Jul 9, 2021

alexcjohnson left a comment

Add satellite and various projection types to geo subplots #5801

Add satellite and various projection types to geo subplots #5801

Conversation

archmoj commented Jul 5, 2021 • edited Loading

nicolaskruchten commented Jul 7, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

archmoj commented Jul 8, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexcjohnson left a comment

Choose a reason for hiding this comment

archmoj commented Jul 5, 2021 •

edited

Loading