-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make d3 internal and stop exporting d3-v3 to the API #5400
Conversation
The reason |
Sure. Do you think that we should still keep strict-d3 around now that IE9 and IE10 are neither supported nor used in development? |
Yes, strict-d3 still has checks that apply to modern browsers - either things different browsers don't agree on, or usage edge cases like style as a getter on unattached elements. |
- use strictD3 in jasmine tests - add strict d3 path to constants - flat domain_ref assets
Thanks for the info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
So this is why I got |
This breaks the ability to do: |
You'll need to import |
Addressing #5395.
Please note that considering the changes made in
src/core.js
,d3-v3
functions e.g.csv
&json
won't be available viaPlotly.d3
.That would help splitting and upgrading d3 sub packages in future possible.
cc: #424.
Also to mention,
The
strict-d3
is moved fromtest/image/strict-d3.js
tosrc/lib/d3.js
and the browserify transform is simplified.update: strict-d3 is moved to
test
and applied in all the jasmine tests.See c71d689
@plotly/plotly_js
cc: @rreusser