Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop generating sitemap.xml.gz (#6561) #6562

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reebalazs
Copy link
Member

@reebalazs reebalazs commented Jan 2, 2025

We generate sitemap-index.xml which is also put correctly into robots.txt. However we still provide the old sitemap.xml.gz.

But, while this serves no purpose in addition to the index, it can cause problems if Google somehow parses it (for example it's submitted to the Google Search console). For this reason, we stop providing sitemap.xml.gz.


Closes #6561

We generate sitemap-index.xml which is also put correctly into robots.txt. However we still provide the old sitemap.xml.gz.

But, while this serves no purpose in addition to the index, it can cause problems if Google somehow parses it (for example it's submitted to the Google Search console). For this reason, we  stop providing sitemap.xml.gz.
@reebalazs reebalazs requested review from sneridagh and tisto January 2, 2025 13:18
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 3ccc9b3
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6776921d9e55540008e6aa35

Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plone/volto-team anybody else feedback?

@sneridagh sneridagh requested a review from a team January 8, 2025 11:21
@ichim-david
Copy link
Member

@sneridagh I asked at Edw and at least as a preliminary reply was that it doesn't affect us as we check also for sitemap-index.xml. So at least for us it seems fine. Waiting to see what the other companies have to say about this but in the meanwhile I wanted to write to comment to know that we've discussed about this and we are ok with these changes

@erral
Copy link
Member

erral commented Jan 9, 2025

I would add a redirect from sitemap.xml.gz to sitemap-index.xml.gz to gracefully handle the change.

@reebalazs
Copy link
Member Author

I would add a redirect from sitemap.xml.gz to sitemap-index.xml.gz to gracefully handle the change.

I think that a redirect, while technically possible, is problematic because sitemap-index.xml is not gzipped and the original one is. So we would serve a file ending with .gz but actually not gzipped. Whether or not google eats this or not, is not possible to find out from the documentation. We could figure out experimentally... but then what if they change things.

So if we don't redirect, then Google either finds the sitemap from robots.txt. or it has to be changed once in the console, but it's explicit and there is no magic behind that might break things in the future.

(The reason for it being not gzipped is because of following the google documentation. It seemed simpler to do the same then to start experimenting what can work and what not.)

@erral
Copy link
Member

erral commented Jan 9, 2025

Sorry I have written it incorrectly, I meant a redirect between sitemap.xml.gz and sitemap-index.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs discussion
Development

Successfully merging this pull request may close these issues.

Do not deliver the old sitemap.xml.gz
4 participants