Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE inline mode Link/Image modal fix #364

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

petschki
Copy link
Member

@mister-roboto
Copy link

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@petschki
Copy link
Member Author

@jenkins-plone-org please run jobs

@petschki
Copy link
Member Author

@gforcada @mauritsvanrees somehow the PR-6.1-py3.12 on jenkins doesnt exist anymore but mr.roboto added it here as check... where can I fix this?

@mauritsvanrees
Copy link
Member

Somewhere in Settings, if you have permission, from the top of my head, go to branches and look for branch protection rules.

@gforcada
Copy link
Member

It might be that after updating mr.roboto configuration I forgot to restart it 🤔 just in case, I did so now. The least path of resistance is to push a new commit, or reorder the commits, amend one, whatever and push again so that new jobs get queued. We can ignore that check and merge if all is fine as well 🤞🏾 ♻️

@petschki petschki force-pushed the petschki-tinymce-inline-fix branch from 0516ef8 to 4591f21 Compare December 28, 2024 11:17
@petschki
Copy link
Member Author

@jenkins-plone-org please run jobs

@petschki
Copy link
Member Author

@gforcada thank you. I change some commits and now the checks are correct.

@mauritsvanrees unfortunately I do not have access to the settings here, but that was not needed anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a link is broken in TinyMCE inline mode in Plone 6.1.0b2
4 participants