-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TinyMCE inline mode Link/Image modal fix #364
base: master
Are you sure you want to change the base?
Conversation
@petschki thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
@gforcada @mauritsvanrees somehow the PR-6.1-py3.12 on jenkins doesnt exist anymore but mr.roboto added it here as check... where can I fix this? |
Somewhere in Settings, if you have permission, from the top of my head, go to branches and look for branch protection rules. |
It might be that after updating |
0516ef8
to
4591f21
Compare
@jenkins-plone-org please run jobs |
@gforcada thank you. I change some commits and now the checks are correct. @mauritsvanrees unfortunately I do not have access to the settings here, but that was not needed anyways. |
fixes plone/Products.CMFPlone#4083