Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes plone-pat-modal redirection issue after changing state from content menu #70

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Fixes plone-pat-modal redirection issue after changing state from content menu #70

merged 3 commits into from
Aug 19, 2024

Conversation

rohnsha0
Copy link
Contributor

fixes #3989

@rohnsha0 rohnsha0 requested a review from petschki August 17, 2024 02:47
@mister-roboto
Copy link

@rohnsha0 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@rohnsha0
Copy link
Contributor Author

pre-commit.ci autofix

@rohnsha0
Copy link
Contributor Author

@jenkins-plone-org please run jobs

@rohnsha0
Copy link
Contributor Author

again same failure

Setup failed:
SessionNotCreatedException: Message: session not created: This version of ChromeDriver only supports Chrome version 124
Current browser version is 127.0.6533.99 with binary path /usr/bin/google-chrome

@petschki
Copy link
Member

@jenkins-plone-org please run jobs

petschki
petschki requested changes Aug 19, 2024
View reviewed changes
Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo in the changes. otherwise LGTM.

news/3989.bugfix Outdated Show resolved Hide resolved
@rohnsha0 @petschki
Update news/3989.bugfix
4d14889 
Co-authored-by: Peter Mathis <[email protected]>
@rohnsha0
Copy link
Contributor Author

Just a typo in the changes. otherwise LGTM.

done...

petschki
petschki approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when green.

@rohnsha0
Copy link
Contributor Author

@jenkins-plone-org please run jobs

@rohnsha0 rohnsha0 merged commit c0f49ec into master Aug 19, 2024
14 checks passed
@rohnsha0 rohnsha0 deleted the rohnsha0-plone-pat-modal-redirection branch August 19, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petschki petschki petschki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plone-pat-modal improper redirect on folder contents (classic UI)
3 participants
@rohnsha0 @mister-roboto @petschki