-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pat contentbrowser: ui improvements for select button in toolbar #1411
Conversation
Good idea. I was also wondering if it makes sense to just use the button for the word select and show the path/ title as text. It was not right away clear to me where i select a folder ;) |
I have shown this solution to our power users/editors. They want a cleaner solution. ‘Less is more’ - just the “Select” button without text, but that would mean the button for the selection should be in the same column above, not in the next right column up. Perhaps is the solution of this PR overloaded? Are we to nerdy in our Plone world ? I convert this PR to a Draft PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I'd not use bootstrap in here but use the browser's
title
mechanism to show tooltips. See me suggestion in code. -
The commit message could be a bit more verbose about what your changes are about.
data-bs-toggle="tooltip" | ||
data-bs-title="{level.displayPath}" | ||
data-bs-placement="top" | ||
data-bs-custom-class="contentbrowser-tooltip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't a title
attribute be enough for showing a tooltip by browser mechanisms?
We could also augment that later using patternslib or something, if the browser tooltip isn't enough.
Background: I overheard that Twitter Bootstrap is in declining development state. And I get always a bit nervous when we add another dependency to Bootstrap.
Also, the browser tooltip mechanism via the title
attribute is fine enough in most cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second to not use Bootstrap here.
data-bs-toggle="tooltip" | ||
data-bs-title="{level.displayPath}" | ||
data-bs-placement="top" | ||
data-bs-custom-class="contentbrowser-tooltip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data-bs-toggle="tooltip" | |
data-bs-title="{level.displayPath}" | |
data-bs-placement="top" | |
data-bs-custom-class="contentbrowser-tooltip" | |
title="{level.displayPath}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of simplifying it. I will change it.
…play path info of selected object
I'm wondering if it make sense at all, that we allow selection of parents. From the user point of view, it seems cleaner that you can only select from the current context, not above. The path element would be than only path elements and not buttons. From the UX, i could see, that we move the select button back inside the last column, where it is either an item (Page, Event, Image...) or another Folder. The Folder of course contains the list of items, but it could also have a select button above "select this container". |
the old behavior was "display the path", now "display the title" and show the path in a tooltip