-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the MPL2.0 license pkg #563
Conversation
WalkthroughThe recent changes streamline the error handling in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
go.sum
is excluded by!**/*.sum
Files selected for processing (2)
- go.mod (2 hunks)
- message/pool/message.go (2 hunks)
Files skipped from review due to trivial changes (1)
- go.mod
Additional comments not posted (3)
message/pool/message.go (3)
620-620
: Simplify error handling by using a slice of error strings.The use of a slice of error strings (
errStr
) simplifies error handling by avoiding themultierror
dependency.
623-623
: Ensure error messages are appended correctly.Appending the error message from the seek operation ensures all errors are captured.
625-625
: Return a formatted error string.Returning a formatted error string with the count of errors and the collected error messages improves clarity and readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- message/pool/message.go (2 hunks)
Additional comments not posted (3)
message/pool/message.go (3)
619-619
: Simplified error collection.The error collection mechanism has been simplified by using a slice of errors. This improves readability and maintainability.
622-622
: Correctly appending seek error to the error slice.The seek error is correctly appended to the error slice if it occurs.
624-624
: Combining errors usingerrors.Join
.The use of
errors.Join
to combine errors is a good practice and aligns with modern Go error handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍
@jkralik maybe we should add the licence scanner (fossa) that we have in other repositories here, hopefully it can be setup in such way to mark MPL as problematic. Because I'll forget about it in a week and we use the multierror package in other repositories, so I can easily see myself re-adding it in the future. 🤓 |
Summary by CodeRabbit
Bug Fixes
Chores