feat: switch doc generation to use helm-docs and add a workflow to auto bump the chart version on pr approval #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookandy
approved these changes
Oct 29, 2024
…to bump the chart version on pr approval
MarshallAsch
force-pushed
the
auto-chart-docs
branch
from
e611226
to
163eaef
Compare
cilindrox
reviewed
Nov 14, 2024
| name: Bump Version and Generate Docs | ||
| on: | ||
| pull_request_review: | ||
| types: [submitted] |
There was a problem hiding this comment.
maybe filter by PRs targetting main or repo's default branch?
Also, dunno how I feel running this on the PR vs on commits to main - IMO the latter would prevent any churn on the PR branch and might reduce any risks with commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inital commits here do not include the new generated version of the chart README to show its generation after the GH approval.
This workflow will update the chart version automatically after receiving an approval from from one of the maintainers. The version will be selected based on the presence of one of the
chart: patch,chart: minor, orchart:majorlabels on the PR.Then the chart documentation will be re generated and committed back to the source branch.
Note: the chart testing linter is expected to fail until after the action is run to bump the chart version