-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple GPU support and improve rclone secret usage in Helm chart #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition.
We have 2 requests, could you please add a minor version bump the the Chart.yaml
file, and re-generate the values file documentation in the README using frigate. (there is a link at the bottom of the readme that can be used)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @rdmcguire
Deferring to @MarshallAsch for final approval.
Co-authored-by: Gaston Festari <[email protected]>
new version shipped. Thanks @rdmcguire ! |
This PR primarily provides a simple way for enabling support for an Nvidia GPU in Kubernetes. Additionally, it copies all keys from the rclone secret into /etc/rclone, which is useful if you want to ship credentials or other files, such as a private key for rclone via sftp.
The values.yaml interface for enabling GPU support is in these keys:
Additionally the config init container command and args are modified to copy all secret keys into the config-data mount, and more useful extraVolumes / extraVolumeMounts comments were added for
/dev/dri
specifically as it is likely to be common for plex.