Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple GPU support and improve rclone secret usage in Helm chart #113

Merged
merged 6 commits into from
Nov 6, 2024

Conversation

rdmcguire
Copy link
Contributor

@rdmcguire rdmcguire commented Oct 15, 2024

This PR primarily provides a simple way for enabling support for an Nvidia GPU in Kubernetes. Additionally, it copies all keys from the rclone secret into /etc/rclone, which is useful if you want to ship credentials or other files, such as a private key for rclone via sftp.

The values.yaml interface for enabling GPU support is in these keys:

pms:
  # Enabling this will add nvidia.com/gpu: 1 to limits, and will set
  # environment for the nvidia operator
  gpu:
    nvidia:
      enabled: false

Additionally the config init container command and args are modified to copy all secret keys into the config-data mount, and more useful extraVolumes / extraVolumeMounts comments were added for /dev/dri specifically as it is likely to be common for plex.

@rdmcguire rdmcguire requested a review from a team as a code owner October 15, 2024 01:12
Copy link
Member

@MarshallAsch MarshallAsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition.

We have 2 requests, could you please add a minor version bump the the Chart.yaml file, and re-generate the values file documentation in the README using frigate. (there is a link at the bottom of the readme that can be used)

charts/plex-media-server/values.yaml Outdated Show resolved Hide resolved
Copy link
Member

@cilindrox cilindrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @rdmcguire

Deferring to @MarshallAsch for final approval.

charts/plex-media-server/Chart.yaml Outdated Show resolved Hide resolved
@MarshallAsch MarshallAsch added the chart: minor Minor version bump label Oct 29, 2024
@cilindrox cilindrox merged commit f004951 into plexinc:master Nov 6, 2024
1 check passed
@cilindrox
Copy link
Member

new version shipped. Thanks @rdmcguire !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart: minor Minor version bump enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants