-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runtimeClassName #105
Add runtimeClassName #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - thanks @thomaspetit
Could you bump the chart's version to 0.4.0
?
Fixed and also signed my commits (as per requirement for allowing this PR) |
f34c8dd
to
770f11f
Compare
@cilindrox can you have a look at the latest commit? I'd love to re-align my homelab to the latest version with gpu acceleration 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I'm validating some local stuff and just noticed that the securityContext is not configureable which basically means that the GPU can be detected but not used by Plex. Probably need to make it configureable too. |
Good call - we went with something a bit too lenient but maybe that whole block can be made configurable and the default value just uses the current settings? LMK and I can keep this PR open |
The security context that you're referring to ise indeed required for I'll check how I can nicely make it fit and ensure we have something non-breaking 👍 |
whoops, bad container - even more straightforward then ;) |
I made an error locally by not adding my encoding package We can merge it if ok for you 🥳 |
🥳 |
This option might be interesting for those that are running a GPU within their kubernetes cluster and want to be able to specify the runtimeClassName manually.