fix: Panics caused by BoundingBox API returning nil #498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
boundingBox
playwright API may returnnil
for the bounding box without setting an error.The Go implementation doesn't support this case, causing null dereference and panics when trying to remap the nil to the matching struct.
We handle this by checking if the value is
nil
before remapping values.This PR fixes this bug by checking for
nil
value before remapping.We can also change the implementation of the remapping but it will require passing pointer to a pointer (
**
) in order to setnil
values for variables.Reference - https://github.com/microsoft/playwright/blob/59a50cf59603850c645830a17ccb05178eb96f50/packages/playwright-core/src/client/elementHandle.ts#L185
Panic Trace