Fixes! #30
Merged
Fixes! #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please share a test report. We can't afford feature degradation rn. |
SaadBazaz
approved these changes
Jan 17, 2024
| @@ -23,7 +24,6 @@ mergeInto(LibraryManager.library, { | |||
| } | |||
|
|
|||
| var options = optionsJson ? JSON.parse(UTF8ToString(optionsJson)) : {}; | |||
| // console.log(options) | |||
There was a problem hiding this comment.
Remove, don't comment.
Keeps the code neat and clean.
| @@ -929,7 +929,7 @@ public void SetState(string key, float value, bool reliable = false) | |||
| { | |||
| if (IsRunningInBrowser()) | |||
| { | |||
| SetPlayerStateFloatByPlayerId(id, key, value.ToString(), reliable); | |||
| SetPlayerStateFloatByPlayerId(id, key, value.ToString(CultureInfo.InvariantCulture), reliable); | |||
There was a problem hiding this comment.
Is this done everywhere where ToString is used? If yes, has it been tested to not have any negative effects?
asadm
approved these changes
Jan 18, 2024
| @@ -12,6 +12,7 @@ mergeInto(LibraryManager.library, { | |||
| // onLaunchCallback | |||
| ) { | |||
| function embedScript(src) { | |||
| script.crossOrigin = 'anonymous'; | |||
There was a problem hiding this comment.
tested this? does this cause any issues?
This was referenced Jan 22, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did a build test on the demo game.