-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails stack #212
Rails stack #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should handle the following cases as well to be able to move this forward:
- Install Bundler (if
Gemfile.lock
exists) - Install dependencies
- Use the proposed Rails and Bundler environment variables
A great deal of work has been done in our Rails template, we should follow the same logic here: https://github.com/platformsh-templates/rails/blob/master/.platform.app.yaml
We might not need to do all the cache directory optimizations, but most of the work in there is valid.
/cc @chadwcarlson @gilzow for confirmation and maybe selection of the MVP for this.
Yes I know those options I documented them from Ori work, the goal is to have a simple working bootstrap with Rails not a perfect one |
2bdcf14
to
37a279b
Compare
Can we give it a go and improve things later? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@spk feel free to check the proposed changes and merge (or let me know to merge myself)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @akalipetis
Allow a rails new project to run directly on upsun, ref #205