Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails stack #212

Merged
merged 10 commits into from
Jul 18, 2024
Merged

Rails stack #212

merged 10 commits into from
Jul 18, 2024

Conversation

spk
Copy link
Contributor

@spk spk commented Mar 15, 2024

Allow a rails new project to run directly on upsun, ref #205

  • make it work on platformsh too

Copy link
Member

@akalipetis akalipetis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should handle the following cases as well to be able to move this forward:

  1. Install Bundler (if Gemfile.lock exists)
  2. Install dependencies
  3. Use the proposed Rails and Bundler environment variables

A great deal of work has been done in our Rails template, we should follow the same logic here: https://github.com/platformsh-templates/rails/blob/master/.platform.app.yaml

We might not need to do all the cache directory optimizations, but most of the work in there is valid.

/cc @chadwcarlson @gilzow for confirmation and maybe selection of the MVP for this.

@spk
Copy link
Contributor Author

spk commented Mar 26, 2024

Yes I know those options I documented them from Ori work, the goal is to have a simple working bootstrap with Rails not a perfect one

@spk spk force-pushed the rails-stack branch 2 times, most recently from 2bdcf14 to 37a279b Compare May 17, 2024 13:04
@spk
Copy link
Contributor Author

spk commented May 17, 2024

Can we give it a go and improve things later?

@spk spk requested a review from akalipetis July 9, 2024 13:36
Copy link
Member

@akalipetis akalipetis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spk feel free to check the proposed changes and merge (or let me know to merge myself)

Copy link
Contributor Author

@spk spk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @akalipetis

@akalipetis akalipetis merged commit 2ddf43f into platformsh:main Jul 18, 2024
@spk spk deleted the rails-stack branch July 18, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants