Rebase to upstream whereabouts #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nicklesimba <[email protected]>
Moved IP Reconciler code into IP Control Loop
…for-bugs Propose issue templates for bugs
automation: provide PR template
Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
…roposals ci automation, docs: maiqueb cares about docs
We had forgotten to request more memory when we added the controller, which furthermore now also runs the `ip-reconciler` cron. Signed-off-by: Miguel Duarte Barroso <[email protected]>
controller: request more memory to prevent runtime OOM kills
storage, etcd: remove backend
* DualStack Proposal Signed-off-by: Ayush Patel <[email protected]> * Update dualstack proposal document - Updated attribute and struct name as per discussion - Minor formatting in proposal document * Added a section for discussion and decisions in dualstack proposal * Added explaination for backward compatibility in dualstack proposal Signed-off-by: Ayush Patel <[email protected]>
This way, we stop relying on 3rd party repos, and have the cni installation script available within the repo. Signed-off-by: Miguel Duarte Barroso <[email protected]>
This commit removes the controller-runtime dependency from the production code. Removing the dependency from the unit-tests will happen on a follow-up commit. Signed-off-by: Miguel Duarte Barroso <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>
These unit tests make no sense - they're generated code, which is known to work. Signed-off-by: Miguel Duarte Barroso <[email protected]>
We will now rely on the fake kubernetes clients to hold the state of the pools / pods / etc, instead of the testing `controller-runtime` objects. Thus, we need to perform dependency injection to inject the "correct" K8s client to the CNI cmd ADD / DEL / CHECK functions. Signed-off-by: Miguel Duarte Barroso <[email protected]>
Some tests that didn't make sense anymore were deleted, while some were ported to the `config` pkg unit tests. Signed-off-by: Miguel Duarte Barroso <[email protected]>
e2e tests: provide cni-install.yml
* Install controller-gen in project-local bin directory Replace the global installation of [email protected] with project-local installation in bin directory Signed-off-by: Ayush Patel <[email protected]> * Install staticcheck before running test Added script to install staticcheck in project-local bin directory before running tests. Also updated the tests to use project-local staticcheck installed in bin directory. Signed-off-by: Ayush Patel <[email protected]> * Updated crd generation script Signed-off-by: Ayush Patel <[email protected]> Signed-off-by: Ayush Patel <[email protected]>
Remove controller runtime
Signed-off-by: Miguel Duarte Barroso <[email protected]>
build, ci: remove the install-kubebuilder-tools script
Signed-off-by: Antonin Bas <[email protected]>
Signed-off-by: Antonin Bas <[email protected]>
Introduce new type 'RangeConfiguration' for encapsulating the fields related to the range from which whereabouts will choose a free IP to be assigned to any pod. Add a new field 'IPRanges' to the struct 'IPAMConfig' which is a array of 'RangeConfiguration'. Whereabouts will assign one free IP from evey range in 'IPRanges' to the pod. Signed-off-by: Ayush Patel <[email protected]>
README.md NodeSliceFastIPAM typo fix
Adds a script that can be used with the the local kind cluster to test the impact of changes to whereabouts from a scale perspective Signed-off-by: Benjamin Pickard <[email protected]>
Signed-off-by: Benjamin Pickard <[email protected]>
Simple scale script
Creates functions to generate the kubeconfig and whereabouts conf use these functions to check if the serviveAccount changes to regen the kubeconfig if it expires Change WHEREABOUTS_FLATFILE to WHEREABOUTS_CONF_FILE for clarity Signed-off-by: Benjamin Pickard <[email protected]>
Add chart release workflow
Add missing crds and options in the chart
…on NAD changes, fix range parameter
during the reconcilation loop we check to see if we have any orphaned Ips, and during this we currently have a 1.5 second sleep. I ran some tests and found a decent perf improvement by dropping this by half, but removing it completely caused issues Signed-off-by: Benjamin Pickard <[email protected]>
Bumps [morphy2k/revive-action](https://github.com/morphy2k/revive-action) from 2.5.7 to 2.5.10. - [Release notes](https://github.com/morphy2k/revive-action/releases) - [Commits](morphy2k/revive-action@v2.5.7...v2.5.10) --- updated-dependencies: - dependency-name: morphy2k/revive-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps openshift/release from golang-1.21 to golang-1.22. --- updated-dependencies: - dependency-name: openshift/release dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 44 to 45. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v44...v45) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [morphy2k/revive-action](https://github.com/morphy2k/revive-action) from 2.5.10 to 2.5.11. - [Release notes](https://github.com/morphy2k/revive-action/releases) - [Commits](morphy2k/revive-action@v2.5.10...v2.5.11) --- updated-dependencies: - dependency-name: morphy2k/revive-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps golang from 1.21 to 1.23. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Reduce Sleep
Signed-off-by: Marcelo Guerrero <[email protected]>
Fix log format for IterateForAssignment
Kubeconfig loop
Fixes for node slice IPAM
Bumps [morphy2k/revive-action](https://github.com/morphy2k/revive-action) from 2.5.11 to 2.6.0. - [Release notes](https://github.com/morphy2k/revive-action/releases) - [Commits](morphy2k/revive-action@v2.5.11...v2.6.0) --- updated-dependencies: - dependency-name: morphy2k/revive-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Marcelo Guerrero <[email protected]>
Align with version used in Dockerfile Signed-off-by: Marcelo Guerrero <[email protected]>
Signed-off-by: Marcelo Guerrero <[email protected]>
Bump Go version 1.23
Bumps [morphy2k/revive-action](https://github.com/morphy2k/revive-action) from 2.6.0 to 2.7.0. - [Release notes](https://github.com/morphy2k/revive-action/releases) - [Commits](morphy2k/revive-action@v2.6.0...v2.7.0) --- updated-dependencies: - dependency-name: morphy2k/revive-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.