sync master branch with upstream #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yulng <[email protected]>
Upgrade gopkg.in/yaml.v2 prior to v2.2.4. Currently this outdated version is indirectly references as follows: github.com/stretchr/testify requires gopkg.in/yaml.v2 v2.2.2 github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0 requires gitub.com/stretchr/testify v1.5.1, and is required by a number of packages. To upgrade from yaml <v2.2.4, ginkgo must be migrated to v2. Additionally, bump the versions of the following to remove indirect dependencies on outdated version of ginkgo, gomega, and slim-sprig: github.com/onsi/gomega github.com/containernetworking/cni github.com/containernetworking/plugins Signed-off-by: Salvatore Daniele <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
Signed-off-by: Sebastian Sch <[email protected]>
bump gopkg.in/yaml.v2
bump golang version to 1.20
add codeql workflow similarly to other projects in k8snetworkplumbingwg org Signed-off-by: adrianc <[email protected]>
Add codeql workflow
make didn't work without it. Signed-off-by: Jiri Prokes <[email protected]>
Bump golangci-lint in Makefile as well
Signed-off-by: adrianc <[email protected]>
Signed-off-by: frbimo <[email protected]>
This change updates "Go test" step in buildtest.yml to include the '-race' flag, enabling race detection in the CI during testing. Signed-off-by: Alina Sudakov <[email protected]>
update multus configuration reference link in README
Remove unused GODOC from Makefile
Signed-off-by: Sebastian Sch <[email protected]>
Enable race detection in unit tests
Signed-off-by: Sebastian Sch <[email protected]>
use make lint in the github actions
Add support to revert VF trust
This commit add a retry function for all the mac address allocation functions. this is needed because some of the drivers have async mac allocation or get a device or resouce busy errors until the vf device is fully configured on the system so instead of failing the CNI we just wait 100 miliseconds Signed-off-by: Sebastian Sch <[email protected]>
- Fix issue in pushing images to master/release with multi-arch build - Bump action versions Signed-off-by: adrianc <[email protected]>
Workflow Maintenance
Signed-off-by: adrianc <[email protected]>
fix typo in push workflows
Add both hardware and nic mac allocation retry
This allows users to set the allmulticast mode for a VF. Signed-off-by: Marcelo Guerrero <[email protected]>
This parameter is only used in a check that is not valid because only a single interface name is used by the plugin. Additionally, the func GetVFLinkNames was renamed to GetVFLinkName to reflect that a single name is returned. Signed-off-by: Marcelo Guerrero <[email protected]>
Add support for allmulticast flag
This allows users to set the vlan protocol. Signed-off-by: Marcelo Guerrero <[email protected]>
Support vlan Proto
- Add check to not allow non default values of qos and proto when vlan is zero. - Remove check when vlan is zero and qos and proto are not in config since default values are now set. Signed-off-by: Marcelo Guerrero <[email protected]>
Fix checks for vlan parameters
Provide a way to choose the container engine with IMAGE_BUILDER var. Signed-off-by: Andreas Karis <[email protected]>
Signed-off-by: Andreas Karis <[email protected]>
Signed-off-by: Andreas Karis <[email protected]>
Add logging to sriov-cni
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.8.0 to 0.17.0. - [Commits](golang/net@v0.8.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…es/golang.org/x/net-0.17.0 Bump golang.org/x/net from 0.8.0 to 0.17.0
Setting the MAC address at the end of SetupVF reduces the chances of race conditions with tools that set MAC address asynchronously (i.e. iavf). This commit solve an issue with i40e driver where calling `SetVFEffectiveMAC` after `SetVFHardwareMAC` may produce a VF with no connectivity even if the last configuration step didn't produce any error: ``` + ip link set dev ens1f0 vf 0 mac 20:04:0f:f1:88:A1 # No error + ip link set dev temp_71 address 20:04:0f:f1:88:A1 # Transient error RTNETLINK answers: Resource temporarily unavailable + ip link set dev temp_71 address 20:04:0f:f1:88:A1 # No error ``` Note: this seems to be a kernel driver regression introduced near torvalds/linux@c34743d Signed-off-by: Andrea Panattoni <[email protected]>
Set MAC address after renaming the interface
- remove "latest" image tage from docker meta - remove use of IMAGE_NAME in manifest creation as docker meta tag is the full image name Signed-off-by: adrianc <[email protected]>
Fix release workflow
set correct platform Signed-off-by: adrianc <[email protected]>
fix platform in image push release workflow
Add a Github Action lane to trigger the SRIOV Network Operator tests. This allows to verify if PR changes break any working scenario. Signed-off-by: Andrea Panattoni <[email protected]>
Signed-off-by: ii2day <[email protected]>
Container image might be used as `initcontainers` in kubernetes Pods. In such scenarios, it's important for the image entrypoint to exits once the copy logic is completed. Otherwise, the pod would stuck in a `PodInitializing` phase. Add Makefile rule `image-test` to check the integrity of the entrypoint.sh script. https://kubernetes.io/docs/concepts/workloads/pods/init-containers/ Signed-off-by: Andrea Panattoni <[email protected]>
Optionally avoid sleeping in `entrypoint.sh`
bump go version to 1.21
Signed-off-by: killianmuldoon <[email protected]>
chore: Add OWNERS file
Add SRIOV Operator CI lane
joey00072
approved these changes
Mar 8, 2024
mithilarun
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.