Check if vip interface exists #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirmoy
reviewed
Jan 15, 2019
|
@ojmhetar I see that
Might be worth checking if that helps. |
|
After trying keepalived:2.0.10, I found that while it does not run with an non-existing interface, it exits with status 0. |
nirmoy
approved these changes
Jan 18, 2019
| config.Networking.PodSubnet, config.MasterConfiguration.Networking.PodSubnet)) | ||
| } | ||
| } | ||
| if config.MasterConfiguration.Networking.DNSDomain != config.Networking.DNSDomain { | ||
| errorList = append(errorList, fmt.Errorf("configuration conflict: Networking.DNSDomain=%q, MasterConfiguration.Networking.DNSDomain=%q. Values should be identical, or MasterConfiguration.Networking.DNSDomain omitted", | ||
| config.Networking.DNSDomain, config.MasterConfiguration.Networking.DNSDomain)) | ||
| } | ||
| if config.VIPConfiguration.RouterID != -1 { |
There was a problem hiding this comment.
Hi Ojas, just curious why not look for NetworkInterface itself here, i think we have a separate check where we verify that both RouterID and NetworkInterface are provided.
There was a problem hiding this comment.
The idea was to only error here if this cluster is intended to be HA. If interface is empty, it could be done intentionally for a non-HA cluster.
puneetguptanitj
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the specified interface does not exist, keepalived will repeatedly kill and respawn a child process. keepalived will not fail fast on an "invalid" configuration, since in some situations it is possible that the interface may come up later. (Is this behavior we want to preserve during init?)
If keepalived is not fully operational, it will not route requests to the APIServer which will cause problems further in the init process.