Upgrade default etcd version to 3.5.17 #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The DCO check seems to be failing 😕. Did you add the |
GuptaManan100
approved these changes
Jan 17, 2025
|
Made the commit from the GitHub webapp. 🤷 |
frouioui
reviewed
Jan 17, 2025
|
Have you tested upgrade paths with a vitess cluster on K8S using the previous etcd version, upgrading to the other etcd version? Same thing with downgrades. |
|
Not tested. PR based on #447. |
|
In this case we need to do #447 (comment) too :) |
GrahamCampbell
force-pushed
the
patch-1
branch
from
79e5ce6 to
99c4a43
Compare
|
Re-pushed with a signed off commit. |
frouioui
previously approved these changes
Jan 21, 2025
There was a problem hiding this comment.
LGTM. Can you modify the release notes summary for the next release (2.15.0) to include a note on how to proceed with this newer etcd version, #447 (comment).
frouioui
reviewed
Jan 21, 2025
GrahamCampbell
force-pushed
the
patch-1
branch
from
99c4a43 to
78cd57f
Compare
Signed-off-by: Graham Campbell <[email protected]>
Signed-off-by: Graham Campbell <[email protected]>
GrahamCampbell
force-pushed
the
patch-1
branch
from
78cd57f to
4089c08
Compare
5 tasks
frouioui
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the default etcd version to 3.5.17.
Corresponding PR on vitess: vitessio/vitess#17653