Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable new onboarding feature flag #1675

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Enable new onboarding feature flag #1675

merged 2 commits into from
Oct 21, 2024

Conversation

joshuatbrown
Copy link
Contributor

@joshuatbrown joshuatbrown commented Oct 21, 2024

Issues covered

None, or all the onboarding ones. (I opened #1673 -Matt)

Description

Enables the new onboarding feature flag by default. This means it'll be always enabled for production, and enabled by default (and still toggleable) for staging and dev. This seemed safer to me than deleting the flag entirely since I rushed through implementing the screens and not all of them have made it through UAT yet.

How to test

  1. Log out
  2. Delete the app
  3. Reinstall
  4. Start onboarding
  5. Ensure you get the new screens, like the new age verification, the Create Account screen with 4 steps, etc.

@mplorentz
Copy link
Member

👀

Copy link
Member

@mplorentz mplorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I like the safe approach.

@mplorentz mplorentz added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 7c52930 Oct 21, 2024
4 checks passed
@mplorentz mplorentz deleted the onboarding-feature-flag branch October 21, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants