Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coredata with relationships between NosNotification and Author #1627

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

mplorentz
Copy link
Member

@mplorentz mplorentz commented Oct 11, 2024

Issues covered

part 1 of #1555

Description

This PR updates core data with relationships between NosNotification and Author

How to test

Nothing to test yet.

@pelumy pelumy marked this pull request as ready for review October 14, 2024 15:14
@pelumy pelumy marked this pull request as draft October 14, 2024 15:20
@pelumy pelumy marked this pull request as ready for review October 14, 2024 15:52
@pelumy pelumy changed the title WIP from pairing Update coredata with relationships between NosNotification and Author Oct 14, 2024
@joshuatbrown
Copy link
Contributor

👀

Copy link
Contributor

@joshuatbrown joshuatbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me and works well!

@mplorentz mplorentz added this pull request to the merge queue Oct 15, 2024
@mplorentz
Copy link
Member Author

I'm merging this so I can branch off the latest core data xcdatamodel file for #1636

Merged via the queue into main with commit ad05b2f Oct 15, 2024
10 checks passed
@mplorentz mplorentz deleted the follow-notifications-in-tab branch October 15, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants