This repository has been archived by the owner on May 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 439
1.x and backward support, missing binary but working otherwise #216
Open
francoisp
wants to merge
27
commits into
pkyeck:develop
Choose a base branch
from
francoisp:master
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support is only for send message/send JSON/send event without ack. Binary are not supported.
Message are parsed more correctly (still not really full proof)
Using JsonStringify object
Thanks to the suggestion of @ploddi
fix when ack number more than 1 digit
fix when ack number more than 1 digit
if response has not "{" character, code was crashed.
Added payload to ping packet as required by engine.io
Small fixes for 64bit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you don't need backward compatibility you should also check out the swift project https://github.com/socketio/socket.io-client-swift