This repository has been archived by the owner on May 14, 2024. It is now read-only.
Fix namespace to use the same socket connection with multiple namespaces. #198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current namespace implementation was not ideal, it would create a new socket connection for each namespace.
In this PR the namespace was removed from SocketIO class.
To share the same socket connection with multiple namespaces the SocketIONamespace class can be used instead.
Basically SocketIONamespace creates a SocketIO singleton which is reused by all SocketIONamespace instances. SocketIONamespace instances register themselves as a delegate of SocketIO.
SocketIO will send events/messages only to the matching namespace SocketIONamespace instance.
pd: SocketIO has an array of weak pointers for the namespaces delegates implemented with a NSPointerArray, which is available on iOS 6 and later.