Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new article metrics plugin to plugins.xml #308

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

indakabarody
Copy link

No description provided.

@indakabarody indakabarody changed the base branch from new-plugin to main September 3, 2024 04:12
@asmecher
Copy link
Member

asmecher commented Sep 6, 2024

Thanks, @indakabarody! @bozana, would you mind reviewing this plugin?

@bozana
Copy link

bozana commented Sep 16, 2024

Hi @indakabarody

I took a look at the plugin and would have a few comments:

  1. You are using these icons in the smarty template file:
    https://i.ibb.co.com/4sq7yLG/ico2.png
    https://i.ibb.co.com/8zQW6X2/ico3.png
    https://ia-education.com/journal/public/site/icon-doi.png.
    We would recommend to use SVG icons. Maybe this site is helpful to search and find adequate SVG icons: https://www.svgrepo.com/ ?
    Also, it would be good to have/provide the icons within the plugin, and not to link to them via URLs.

  2. You use a PDF icon for Downloads, but the galleys could also be in a different format, e.g. HTML, so a more generic icon would probably better fit for that, I think.

  3. There are some hard coded words in your smarty template -- for example "views" and "Downloads". I will suggest to put them into the locale.po file, so that they can be translated and have properly meaning in different languages.

  4. It would be good to use _doiURLEncode function (you can find the function in the DOIPubIdPlugin.php) when displaying the DOI.

  5. There are two functions that are not used by the plugin. They can be removed.

  6. The certification type can be "reviewed" in your PR for the plugin_gallery.

I also think that the plugin name is a little bit too generic -- one could think that the plugin calculates some article metrics, for example -- but I still have no good suggestion for another name :-)

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants