pkp/pkp-lib#8333 Replaced CONTEXT_ID_NONE by SITE_CONTEXT_ID

pkp · Jul 23, 2024 · e2ddc3c · e2ddc3c
1 parent 908ab97
commit e2ddc3c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/classes/services/NavigationMenuService.php b/classes/services/NavigationMenuService.php
@@ -49,7 +49,7 @@ public function __construct()
      */
     public function getMenuItemTypesCallback($hookName, $args)
     {
-        $types = & $args[0];
+        $types = &$args[0];
 
         $ompTypes = [
             self::NMI_TYPE_CATALOG => [
@@ -64,7 +64,7 @@ public function getMenuItemTypesCallback($hookName, $args)
 
         $request = Application::get()->getRequest();
         $context = $request->getContext();
-        $contextId = $context ? $context->getId() : Application::CONTEXT_ID_NONE;
+        $contextId = $context?->getId() ?? Application::SITE_CONTEXT_ID;
 
         $series = Repo::section()
             ->getCollector()
@@ -109,7 +109,7 @@ public function getMenuItemTypesCallback($hookName, $args)
      */
     public function getMenuItemCustomEditTemplatesCallback($hookName, $args)
     {
-        $templates = & $args[0];
+        $templates = &$args[0];
 
         $ompTemplates = [
             self::NMI_TYPE_CATEGORY => [
@@ -131,7 +131,7 @@ public function getMenuItemCustomEditTemplatesCallback($hookName, $args)
      */
     public function getDisplayStatusCallback($hookName, $args)
     {
-        $navigationMenuItem = & $args[0];
+        $navigationMenuItem = &$args[0];
 
         $request = Application::get()->getRequest();
         $dispatcher = $request->getDispatcher();
@@ -140,7 +140,7 @@ public function getDisplayStatusCallback($hookName, $args)
         $isUserLoggedIn = Validation::isLoggedIn();
         $isUserLoggedInAs = (bool) Validation::loggedInAs();
         $context = $request->getContext();
-        $contextId = $context ? $context->getId() : Application::CONTEXT_ID_NONE;
+        $contextId = $context?->getId() ?? Application::SITE_CONTEXT_ID;
 
         $this->transformNavMenuItemTitle($templateMgr, $navigationMenuItem);
 

diff --git a/classes/submission/Collector.php b/classes/submission/Collector.php
@@ -151,7 +151,7 @@ public function getQueryBuilder(): Builder
                 $assocType = Application::ASSOC_TYPE_PRESS;
                 $assocIds = is_array($this->contextIds)
                     ? $this->contextIds
-                    : [Application::CONTEXT_ID_NONE];
+                    : [Application::SITE_CONTEXT_ID];
             }
 
             $q->leftJoin('features as sf', function ($join) use ($assocType, $assocIds) {

diff --git a/controllers/grid/navigationMenus/form/NavigationMenuItemsForm.php b/controllers/grid/navigationMenus/form/NavigationMenuItemsForm.php
@@ -39,7 +39,7 @@ public function fetch($request, $template = null, $display = false)
 
         $request = Application::get()->getRequest();
         $context = $request->getContext();
-        $contextId = $context ? $context->getId() : Application::CONTEXT_ID_NONE;
+        $contextId = $context?->getId() ?? Application::SITE_CONTEXT_ID;
 
         $series = Repo::section()
             ->getCollector()