Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default surname #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

forderation
Copy link

add default surname for XML scheme before deposit.
a current existing plugin was an error when the family name is empty like this:

The content of element 'person_name' is not complete. One of '{"http://www.crossref.org/schema/4.3.6":surname}' is expected.

So the idea is use last section given name to provide surname when the family name is empty

@forderation forderation force-pushed the feature/main/default-surname branch from f248c89 to b637798 Compare February 19, 2022 20:09
@asmecher
Copy link
Member

Hi @forderation! The issue this is addressing is filed in Github with some discussion of a best approach here:

pkp/pkp-lib#7528

Have you seen that issue and its discussion?

@forderation
Copy link
Author

forderation commented Feb 20, 2022

Hi @forderation! The issue this is addressing is filed in Github with some discussion of a best approach here:

pkp/pkp-lib#7528

Have you seen that issue and its discussion?

yes the issue are same, but for alt-name i didn't see as well make the problem. AFAIK i already implemented in our modified ojs 3.2.1 and so far there is no problem with validation

@ewhanson
Copy link
Collaborator

Hi @forderation, thanks for putting this together! I've taken a look and left a few comments.

The discussion in pkp/pkp-lib#7528 recommends putting the OJS given name in the Crossref surname field if there is no family name provided in OJS. The pubmed plugin has a good example of how this has already been implemented in OJS:

https://github.com/pkp/ojs/blob/c8bba4d113a40ae3b9d997d90271b342aa8f9d29/plugins/importexport/pubmed/filter/ArticlePubMedXmlFilter.inc.php#L220-L235

Given the discussion mentioned in the issue and the pubmed example, I would recommend using a similar approach here as well. That way the same problems are solved in the same way across the code base. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants