+encore.dev

[kevinmichaelchen]

blocked by #2896

• they use go 1.21.0 to build
• go 1.21 release
  • released last week 2023-08-08
• ldflags

[kevinmichaelchen]

go mod download is failing

go: cuelang.org/[email protected]: GOPROXY list is not the empty string, but contains no entries

[jhheider]

Peculiar. No package in our pantry sets GOPROXY. Maybe try explicitly setting it to the empty string?

[jhheider]

seems like it might be related to 1.21.0. i'll see what I can find.

https://github.com/teaxyz/pantry/actions/runs/5860883067/job/15889888782

[kevinmichaelchen]

golang/go#61928

[jhheider]

yup d3a903f

[jhheider]

Based on their build instructions and release logic, it looks like this is going to involved building and depending on encore-go:

https://github.com/encoredev/encore/blob/main/.github/workflows/release.yml

and setting some envvars: https://github.com/encoredev/encore/blob/main/CONTRIBUTING.md

[kevinmichaelchen]

I didn't realize they forked the Go language! Is best practice for https://github.com/encoredev/go to be a separate Tea package?

[jhheider]

I think so. Since it is renamed, not much risk of conflict.

[jhheider]

gonna mark this as go. thanks, @kevinmichaelchen !

[mxcl]

like what is this exactly?

Since it causes conflict with google’s go and it seems to just be some kind of fork of go, I'm wondering what it is? I can't find mention of it at encore.dev.

Refs pkgxdev/pkgx#748

[jhheider]

We can almost certainly add a link to encore-go and omit the provides for vanilla go. I think that's even in their docs. I'll do that today, to remove this conflict.

[mxcl]

IMO it's ok just to remove the provides and then encore users can just do tea +encore.dev go. However the longer form encore-go in addition as a provides is also a good idea

[jhheider]

c90d397