Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macvim.org #2756

Merged
merged 16 commits into from
Sep 7, 2023
Merged

macvim.org #2756

merged 16 commits into from
Sep 7, 2023

Conversation

and-ri
Copy link
Contributor

@and-ri and-ri commented Aug 6, 2023

closes #746

runtime:
env:
PYTHONHOME: "{{deps.python.org.prefix}}"
DYLD_LIBRARY_PATH: "{{deps.python.org.prefix}}/lib/libncurses.6.dylib:$DYLD_LIBRARY_PATH"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right; wouldn't it be deps.invisible-island.net/ncurses/prefix? I also worry about setting PYTHONHOME.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh DYLD_LIBRARY_PATH it's my mistake 😄

without PYTHONHOME I have:

Could not find platform independent libraries <prefix>thon3'
Could not find platform dependent libraries <exec_prefix>
Python path configuration:
  PYTHONHOME = (not set)
  PYTHONPATH = (not set)

@and-ri
Copy link
Contributor Author

and-ri commented Aug 26, 2023

I hope #3121 helps.

@and-ri
Copy link
Contributor Author

and-ri commented Aug 26, 2023

hmm... strange
Perhaps the changes (#3121) will take effect later?

@jhheider
Copy link
Contributor

I don't see a dep on ncurses. Could that be the issue?

@jhheider
Copy link
Contributor

You probably need to call fix-machos manually on the app dir so it updates the library paths. See fixup.ts for invocation (or search for fix-machos.rb; I think some other packages might call it manually too).

@jhheider
Copy link
Contributor

jhheider commented Sep 6, 2023

bam

@and-ri and-ri marked this pull request as ready for review September 7, 2023 07:08
@jhheider jhheider merged commit 3390af6 into pkgxdev:main Sep 7, 2023
17 checks passed
@and-ri and-ri deleted the new/macvim.org branch September 20, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

+macvim (545/548)
2 participants