deno 1.4.0

pkgxdev · Jan 29, 2024 · 76a2944 · 76a2944
1 parent 653cd58
commit 76a2944
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/deno.json b/deno.json
@@ -10,10 +10,10 @@
       ]
     }
   },
-  "pkgx": "deno^1.33.3 npm",
+  "pkgx": "deno~1.40.2 npm",
   "tasks": {
-    "test": "deno test --parallel --unstable --allow-env --allow-read --allow-net=dist.pkgx.dev,github.com,codeload.github.com --allow-write --allow-run=tar,uname,/bin/sh,foo,'C:\\Windows\\system32\\cmd.exe'",
-    "typecheck": "deno check --unstable ./mod.ts",
+    "test": "deno test --parallel --unstable-fs --allow-env --allow-read --allow-net=dist.pkgx.dev,github.com,codeload.github.com --allow-write --allow-run=tar,uname,/bin/sh,foo,'C:\\Windows\\system32\\cmd.exe'",
+    "typecheck": "deno check ./mod.ts",
     "dnt": ".github/deno-to-node.ts"
   },
   "lint": {

diff --git a/src/hooks/useSync.ts b/src/hooks/useSync.ts
@@ -1,5 +1,3 @@
-// deno-lint-ignore-file no-deprecated-deno-api
-// ^^ Deno.Command is not implemented for dnt shims yet
 import { deno } from "../deps.ts"
 const { streams: { writeAll } } = deno
 import { flock } from "../utils/flock.deno.ts"
@@ -41,6 +39,8 @@ export default async function(logger?: Logger) {
     // ∴ download the latest tarball and uncompress over the top
     //FIXME deleted packages will not be removed with this method
     const src = new URL(`https://github.com/pkgxdev/pantry/archive/refs/heads/main.tar.gz`)
+    // https://github.com/denoland/node_shims/issues/110
+    // deno-lint-ignore no-deprecated-deno-api
     const proc = Deno.run({
       cmd: ["tar", "xzf", "-", "--strip-components=1"],
       cwd: pantry_dir.string,
@@ -77,6 +77,8 @@ export interface RunOptions {
 async function run(opts: RunOptions) {
   const cmd = opts.cmd.map(x => `${x}`)
   const env = (({ HTTP_PROXY, HTTPS_PROXY }) => ({ HTTP_PROXY, HTTPS_PROXY }))(Deno.env.toObject())
+  // https://github.com/denoland/node_shims/issues/110
+  // deno-lint-ignore no-deprecated-deno-api
   const proc = Deno.run({ ...opts, cmd, stdout: 'null', clearEnv: true, env })
   try {
     const exit = await proc.status()

diff --git a/src/plumbing/install.ts b/src/plumbing/install.ts
@@ -1,6 +1,3 @@
-// deno-lint-ignore-file no-deprecated-deno-api
-// ^^ dnt doesn’t support Deno.Command yet so we’re stuck with the deprecated Deno.run for now
-
 import { Package, Installation, StowageNativeBottle } from "../types.ts"
 import useOffLicense from "../hooks/useOffLicense.ts"
 import useDownload from "../hooks/useDownload.ts"
@@ -49,6 +46,7 @@ export default async function install(pkg: Package, logger?: Logger): Promise<In
       //NOTE ^^ inside pkgx prefix to avoid TMPDIR is on a different volume problems
     })
     const tar_args = compression == 'xz' ? 'xJf' : 'xzf'  // laughably confusing
+    // deno-lint-ignore no-deprecated-deno-api
     const untar = Deno.run({
       cmd: ["tar", tar_args, "-", "--strip-components", (pkg.project.split("/").length + 1).toString()],
       stdin: 'piped', stdout: "inherit", stderr: "inherit",

diff --git a/src/utils/host.test.ts b/src/utils/host.test.ts
@@ -34,7 +34,7 @@ Deno.test({
   }
 
   async function run(cmd: string) {
-    // deno’s shims don’t support Deno.Command yet
+    // https://github.com/denoland/node_shims/issues/110
     // deno-lint-ignore no-deprecated-deno-api
     const proc = Deno.run({ cmd: cmd.split(" "), stdout: "piped" })
     assert((await proc.status()).success)