Use joda-time 2.8.1 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates joda-time to version 2.8.1. This is due to a bug in older versions of joda-time which cause it to [break when used with the AWS SDK](aws/aws-sdk-java#484).
|
@pjstadig can confirm this works and doesn't do all the prefix malarky that's in this branch https://github.com/pjstadig/lein-maven-s3-wagon/pull/5/files |
|
@omarkj thanks! In regards to the version number, we should keep it at 0.2.5-SNAPSHOT, and when I do a release it will get bumped. I think I'm fine with this being a bugfix release, since I assume that it fixes the issue, and nothing else breaks. |
@pjstadig asked for the version number to be changed back to 0.2.5-SNAPSHOT.
|
@pjstadig Yes, this fixes the issue but I am not aware of anything breaking in joda-time 2.8.1. I did skim over the changes. I've changed the version number as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates joda-time to version 2.8.1. This is due to a bug in older versions of
joda-time which cause it to break when used with the AWS SDK.
This bumps the version to
0.2.6-SNAPSHOT. I'm unsure on the version strategy, just let me knowif this is not the version number you'd like.