Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Content Fitting Mode Option on Fancy Button #202

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bbazukun123
Copy link
Collaborator

@bbazukun123 bbazukun123 commented Oct 28, 2024

  • Add the optional contentFittingMode option on FancyButton which defaults to default:
    • default: Text and icon content are constrained within the dimensions of the button view as before, with padding accounted for. ie. if content dimensions exceed that of the view - paddings, they will scale down just enough to fit. Otherwise they will remain at their default scale.
    • fill: Text and icon content are scaled proportionally to fill the button view, with padding accounted for but without exceeding dimensions. Here, the optional default scale options will apply on top of the content after the filling is done.
    • none: Text and icon content will always remain at their default scale regardless of the button view dimensions and padding.
  • Deprecate the optional ignoreRefitting as it was previously meant to allow for the legacy behaviour of the content fitting which is not desirable. ie. the content will preserve its down scaling and won't reset to its base scale even if the updated button view dimensions are be able to accommodate their base dimensions (Logic remains intact for the rare case of it still being in use).
  • Add the contentFittingMode option on the FancyButtonNineSliceSprite example.
  • Lint fixes for the examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant