-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add local fonts loader #17
Conversation
Allow local fonts loading primary ans base stuff.
Easly test fonts, custom fonts with most popular language with special charactere. Using free translate.yandex API.
This is awesome! My only feedback is that: would you mind encapsulating the translation and font stuff into separate components? You're overloading the main TextStyleEditor class. After this is merged, I'm going to upgrade to React, TypeScript, Bootstrap 4, and a more current toolchain. mithril is no longer serving us well if we are going to start making this tool more complex. |
sure, am noob with this kind of environment project but i studying how you do from the other pr, i will try my best to refactoring this more clean soon as possible. then there will remain a small detail which is piss me off since the beginning, is these colors selector window, my first attempt fail, but I think I understand better the architecture of the project now, i will try again the implementation of http://jscolor.com/ |
I’m also happy to clean this up, if that’s easier. As far as the color selector, moving to React will be helpful as there are more components in that ecosystem. Hold off on that for now, I can tackle it in the next iteration. |
ok thank it almost done. i didn't know that |
ho ok forget me Am curious if we can up the limit of this from browser ? |
Done, I tried to do the best I could to do as you did for the other pr, but I didn't get there, I was get errors on errors and very difficult to debug without correct environment. everything works well and tested, but I think you will need make a clean pass, because I can not do better with my programming knowledge. |
Great work thanks |
Closing this and replacing with #20, will do a follow-up with translation afterwards. Fonts seems more important to get in right away. |
Allow local fonts loading, cool feature
Work fine but plz wait, need add more stuff like base64 to sessionStorage and clear for reset custom fonts cache.
Maybe finish this tonight or tomorrow.
this will useful for me and i think some people also request this
#14 (comment)