Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider removing the window.activeBorder color #15

Open
mkhl opened this issue Nov 19, 2022 · 6 comments
Open

consider removing the window.activeBorder color #15

mkhl opened this issue Nov 19, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@mkhl
Copy link

mkhl commented Nov 19, 2022

it might be just me but the border around the whole window looks really out of place (active windows from other applications have a heavier drop shadow, not a border around them)

what's worse is that borders defined by the theme can't be removed in the settings, only recolored, so i currently have to modify the theme after installing it 😒

apart from that i love it though, thank you!

@piousdeer
Copy link
Owner

Could you illustrate the problem with a screenshot? Looks consistent with libadwaita apps to me: in both cases the border is always present on the window regardless of whether it's active.

@mkhl
Copy link
Author

mkhl commented Nov 22, 2022

here's vscode with the theme border (noticeable as a thin line around the status bar)
VSCode

maybe i'm confused as to which apps actually use libadwaita but here's gnome text editor
gnome text editor
and nautilus
nautilus

neither of which have this kind of border at the bottom as far as i can see

@piousdeer
Copy link
Owner

I see it looks annoying when using the colorful status bar option. The libadwaita apps on your screenshots have a border too, but the difference is that it's semi-transparent and drawn over the window contents. Since window.activeBorder is drawn separately and can't be transparent, I'll remove it in a future release.

@piousdeer piousdeer added the bug Something isn't working label Nov 22, 2022
@mkhl
Copy link
Author

mkhl commented Nov 22, 2022

The libadwaita apps on your screenshots have a border too, but the difference is that it's semi-transparent and drawn over the window contents.

ohh i see, thank you for explaining

Since window.activeBorder is drawn separately and can't be transparent, I'll remove it in a future release.

perfect, thanks!

@mkhl
Copy link
Author

mkhl commented Nov 30, 2022

i've switched to dark mode for a while now and the border around libadwaita apps is much more noticeable, so now i'm not sure if removing it from this theme is a good idea after all

@piousdeer
Copy link
Owner

Personally, I use Rounded Window Corners. It can be configured to create a consistent semi-transparent border around all windows, libadwaita or not.

Anyway, the next version of this theme will have options configurable via settings.json. Whether to enable window.activeBorder can be one of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants