Amend review feedback

- Remove ReciprocalSafe as division by zero is an intended feature of computing the inverse of the ray direction

src/collider/BVHTree.cpp

@@ -46,7 +46,7 @@ void SingleBVHTreeBase::Build(const AABBd &bounds, AABBd *objAabbs, uint32_t num
 	// compute a remapping term to express object positions with highest precision using single floating point
 	// use the average of the bounding volume to remap into [-1 .. 1] space
 	m_boundsCenter = (bounds.max + bounds.min) * 0.5;
-	vector3d inv_scale = (bounds.max - m_boundsCenter).ReciprocalSafe();
+	vector3d inv_scale = 1.0 / (bounds.max - m_boundsCenter);
 	m_inv_scale_factor = (inv_scale.x + inv_scale.y + inv_scale.z) / 3.0;
 
 	// Build a vector of sort keys for individual nodes (position within system)

src/collider/Geom.cpp

@@ -197,7 +197,9 @@ void Geom::CollideEdgeTris(std::vector<CollisionContact> &contacts, const matrix
 	isect.triIdx = -1;
 
 	isect_buf.clear();
-	b->GetGeomTree()->GetTriTree()->TraceRay(v1, dir.ReciprocalSafe(), edge.len, isect_buf, triNode);
+	// Taking the reciprocal of the direction computes the inverse of the vector.
+	// Division by zero is intended and correct in this situation.
+	b->GetGeomTree()->GetTriTree()->TraceRay(v1, 1.0 / dir, edge.len, isect_buf, triNode);
 
 	// TODO
 	// This is subtly dependent on overwriting intersections with the last triangle to be processed

src/collider/GeomTree.cpp

@@ -227,7 +227,8 @@ GeomTree::GeomTree(Serializer::Reader &rd)
 void GeomTree::TraceRay(const vector3f &start, const vector3f &dir, isect_t *isect) const
 {
 	std::vector<uint32_t> tri_isect;
-	m_triTree->TraceRay(vector3d(start), vector3d(dir).ReciprocalSafe(), FLT_MAX, tri_isect);
+	// Division by zero is intended and produces correct results in this case
+	m_triTree->TraceRay(vector3d(start), 1.0 / vector3d(dir), FLT_MAX, tri_isect);
 
 	for (uint32_t triIdx : tri_isect) {
 		RayTriIntersect(1, start, &dir, triIdx * 3, isect);

src/vector3.h

@@ -150,15 +150,6 @@ class alignas(sizeof(T)) vector3 {
 		}
 	}
 
-	// Compute the reciprocal of the vector (1.0 / v), avoiding division by zero
-	vector3 ReciprocalSafe() const
-	{
-		return vector3(
-			x == 0.0 ? 0.0 : 1.0 / x,
-			y == 0.0 ? 0.0 : 1.0 / y,
-			z == 0.0 ? 0.0 : 1.0 / z);
-	}
-
 	void Print() const { printf("v(%f,%f,%f)\n", x, y, z); }
 
 	/* Rotate this vector about point o, in axis defined by v. */