Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint, more linters #289

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Upgrade golangci-lint, more linters #289

merged 1 commit into from
Jan 10, 2025

Conversation

JoeTurki
Copy link
Member

@JoeTurki JoeTurki commented Jan 10, 2025

Description

This is the first PR of two I fixed all the issues that doesn't require refactor, ignored the ones that does.

pion/.goassets#220

@JoeTurki JoeTurki mentioned this pull request Jan 10, 2025
3 tasks
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 89.82036% with 17 lines in your changes missing coverage. Please review.

Project coverage is 83.70%. Comparing base (cd52e6b) to head (9f84b58).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
header_extension.go 47.61% 11 Missing ⚠️
codecs/vp9/header.go 86.66% 2 Missing ⚠️
vlaextension.go 83.33% 1 Missing and 1 partial ⚠️
codecs/vp9_packet.go 93.33% 1 Missing ⚠️
packet.go 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
- Coverage   83.71%   83.70%   -0.01%     
==========================================
  Files          24       24              
  Lines        2450     2535      +85     
==========================================
+ Hits         2051     2122      +71     
- Misses        340      354      +14     
  Partials       59       59              
Flag Coverage Δ
go 83.70% <89.82%> (-0.01%) ⬇️
wasm 83.03% <89.22%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoeTurki JoeTurki force-pushed the fix/lint branch 2 times, most recently from 5f2995e to 062bcc7 Compare January 10, 2025 05:59
Copy link
Member Author

@JoeTurki JoeTurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoeTurki JoeTurki merged commit fee4338 into master Jan 10, 2025
15 checks passed
@JoeTurki JoeTurki deleted the fix/lint branch January 10, 2025 18:28
@JoeTurki JoeTurki mentioned this pull request Jan 18, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant