fix issue with Packet.PaddingSize #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix issue where subsequent unmarshalled packets are not initialized with correct padding size
Sean-Der
force-pushed
the
fix-packet-paddingsize
branch
from
3d2cbaf to
4566524
Compare
|
Amazing, thank you so much @strangesast sorry this took so long :( |
Sean-Der
approved these changes
Dec 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #284 +/- ##
==========================================
- Coverage 83.95% 83.71% -0.25%
==========================================
Files 24 24
Lines 1957 2450 +493
==========================================
+ Hits 1643 2051 +408
- Misses 255 340 +85
Partials 59 59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memory from previous calls to Unmarshal is not correctly reset with zero value. this causes issues when decoding packets into the same packet interface and causes payloads to be decoded incorrectly