Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix version syncer doesn't print who hasn't synced on partial sync (#58511) #58754

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #58511

What problem does this PR solve?

Issue Number: close #58480

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

tiup playground; add sleep(5 seconds) on domain reload, and then start a tidb with this PR. run create table

before

[2024/12/24 18:28:04.889 +08:00] [INFO] [syncer.go:403] ["syncer check all versions, all nodes are not synced"] [category=ddl] ["ddl job id"=111] [ver=55]
[2024/12/24 18:28:05.891 +08:00] [INFO] [syncer.go:403] ["syncer check all versions, all nodes are not synced"] [category=ddl] ["ddl job id"=111] [ver=55]

after

[2024/12/24 18:45:50.058 +08:00] [INFO] [syncer.go:398] ["syncer check all versions, someone is not synced"] [category=ddl] [info="instance ip 192.168.206.89, port 5000, id 8d02f9b2-bfe1-4292-a1ef-5c1ef86eebf8"] ["ddl job id"=117] [ver=58]
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jan 7, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2025
Copy link
Member

@joccau joccau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2025
Copy link

ti-chi-bot bot commented Jan 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-07 08:21:54.463823551 +0000 UTC m=+255457.752655256: ☑️ agreed by D3Hunter.
  • 2025-01-07 08:31:55.760035371 +0000 UTC m=+256059.048867076: ☑️ agreed by joccau.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@3ac9806). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #58754   +/-   ##
================================================
  Coverage               ?   56.8979%           
================================================
  Files                  ?       1770           
  Lines                  ?     627499           
  Branches               ?          0           
================================================
  Hits                   ?     357034           
  Misses                 ?     246349           
  Partials               ?      24116           
Flag Coverage Δ
integration 36.9802% <71.4285%> (?)
unit 72.5951% <28.5714%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8711% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.1039% <0.0000%> (?)

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, joccau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit fe0bc60 into pingcap:release-8.5 Jan 7, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants