-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix version syncer doesn't print who hasn't synced on partial sync (#58511) #58754
ddl: fix version syncer doesn't print who hasn't synced on partial sync (#58511) #58754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #58754 +/- ##
================================================
Coverage ? 56.8979%
================================================
Files ? 1770
Lines ? 627499
Branches ? 0
================================================
Hits ? 357034
Misses ? 246349
Partials ? 24116
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, D3Hunter, joccau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #58511
What problem does this PR solve?
Issue Number: close #58480
Problem Summary:
What changed and how does it work?
Check List
Tests
tiup playground
; add sleep(5 seconds) on domain reload, and then start a tidb with this PR. runcreate table
before
after
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.