Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain,executor: handle some cases tidb cannot exit #58501

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #58418

Problem Summary:

What changed and how does it work?

The ctx passed to owner manager is background context, and the owner manager does not respond to domain cancel.

Another thing is that when tikv is gone, TableByName returns error, but getLocalTemporaryTable ignores the error.
The returned is nil, some code get nil pointer runtime panic.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

When tikv OOM, and Ctrl+C can't make tidb exit
dlv attach the tidb process to check where it's blocking ...

After this fix, there are still some other places, fixing all the problems once seems too difficult.

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 24, 2024
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 24, 2024
Copy link

tiprow bot commented Dec 24, 2024

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tiancaiamao
Copy link
Contributor Author

/check-issue-triage-complete

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 30 lines in your changes missing coverage. Please review.

Project coverage is 75.0460%. Comparing base (384f858) to head (7d7b48e).
Report is 9 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58501        +/-   ##
================================================
+ Coverage   73.5301%   75.0460%   +1.5159%     
================================================
  Files          1681       1726        +45     
  Lines        464298     473853      +9555     
================================================
+ Hits         341399     355608     +14209     
+ Misses       102058      95962      -6096     
- Partials      20841      22283      +1442     
Flag Coverage Δ
integration 49.3303% <44.4444%> (?)
unit 72.4756% <35.1851%> (+0.1721%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.6388% <ø> (+15.8762%) ⬆️

Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's easy, please write a unit test to reveal the bug that ignoring error of getLocalTemporaryTable causes panic

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 24, 2024
Copy link

ti-chi-bot bot commented Dec 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 25, 2024
Copy link

ti-chi-bot bot commented Dec 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-24 08:19:33.102870226 +0000 UTC m=+1549763.191672770: ☑️ agreed by lance6716.
  • 2024-12-25 05:13:37.364500177 +0000 UTC m=+1625007.453302719: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot merged commit 40d2481 into pingcap:master Dec 25, 2024
26 checks passed
@tiancaiamao tiancaiamao deleted the exit branch December 25, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants