-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain,executor: handle some cases tidb cannot exit #58501
Conversation
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/check-issue-triage-complete |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58501 +/- ##
================================================
+ Coverage 73.5301% 75.0460% +1.5159%
================================================
Files 1681 1726 +45
Lines 464298 473853 +9555
================================================
+ Hits 341399 355608 +14209
+ Misses 102058 95962 -6096
- Partials 20841 22283 +1442
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's easy, please write a unit test to reveal the bug that ignoring error of getLocalTemporaryTable
causes panic
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #58418
Problem Summary:
What changed and how does it work?
The ctx passed to owner manager is background context, and the owner manager does not respond to domain cancel.
Another thing is that when tikv is gone,
TableByName
returns error, butgetLocalTemporaryTable
ignores the error.The returned is nil, some code get nil pointer runtime panic.
Check List
Tests
When tikv OOM, and Ctrl+C can't make tidb exit
dlv attach the tidb process to check where it's blocking ...
After this fix, there are still some other places, fixing all the problems once seems too difficult.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.