Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: disable some json function from pushdown to TiFlash #56177

Conversation

windtalker
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #56173

Problem Summary:
The root cause is TiFlash does not support json compare, it just use string compare instead. So currently, we need disable pushing down such functions to TiFlash

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xufei <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 20, 2024
Copy link

tiprow bot commented Sep 20, 2024

Hi @windtalker. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.7101%. Comparing base (a97aa45) to head (a009262).
Report is 930 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56177         +/-   ##
=================================================
- Coverage   72.9898%   56.7101%   -16.2798%     
=================================================
  Files          1611       1736        +125     
  Lines        447632     630700     +183068     
=================================================
+ Hits         326726     357671      +30945     
- Misses       100915     249563     +148648     
- Partials      19991      23466       +3475     
Flag Coverage Δ
integration 38.0715% <0.0000%> (?)
unit 72.9466% <100.0000%> (+0.8631%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 53.0030% <ø> (+7.1269%) ⬆️

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 20, 2024
Copy link

ti-chi-bot bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XuHuaiyu, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 20, 2024
Copy link

ti-chi-bot bot commented Sep 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-20 04:05:58.948962325 +0000 UTC m=+1193228.689386256: ☑️ agreed by yibin87.
  • 2024-09-20 04:53:08.134702174 +0000 UTC m=+1196057.875126113: ☑️ agreed by XuHuaiyu.

@ti-chi-bot ti-chi-bot bot merged commit ff1f862 into pingcap:master Sep 20, 2024
22 of 23 checks passed
@windtalker windtalker deleted the disable_some_json_function_pushdown_to_tiflash branch September 23, 2024 07:39
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Sep 23, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #56223.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #56224.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 23, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 23, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #56225.

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 24, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 24, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #59196.

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jan 26, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 26, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #59205.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect query result using tiflash
4 participants