Update go.mod #71
Update go.mod #71
Conversation
There was a problem hiding this comment.
Consider using https://github.com/gregwebs/errors that I have been updating and maintaining.
It has some breaking changes compared to pingcap/errors but the most commonly used functions are still just the same.
|
|
||
| require ( | ||
| github.com/davecgh/go-spew v1.1.1 // indirect | ||
| github.com/pmezard/go-difflib v1.0.0 // indirect |
There was a problem hiding this comment.
From go mod tidy. go mod graph should be able to tell you more about the content
There was a problem hiding this comment.
these are all from testify. Its a pitty that testing dependencies are always pulled for every go project and not kept separate. In my fork I didn't update to a better testing library for this reason. I am also trying out github.com/shoenig/test which has similar functionality as testify but only pulls in github.com/google/go-cmp
| @@ -1,8 +1,14 @@ | |||
| module github.com/pingcap/errors | |||
|
|
|||
| go 1.14 | |||
| go 1.21 | |||
There was a problem hiding this comment.
It's good for a library to keep a lower go mod version if it doesn't need a newer one.
There was a problem hiding this comment.
Sure. That's why I didn't set it to 1.23.
I think the version should be in support? (see https://go.dev/doc/devel/release#:~:text=Each%20major%20Go%20release%20is%20supported%20until%20there%20are%20two%20newer%20major%20releases )
No description provided.