Fix Issue #200 #201
Closed
Fix Issue #200 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeError: mime.lookup is not a function is checked before use. No difference in functionality but fixes important error for dependent modules.
|
This just gets around one error you will see.this module and modules that use it expect the mime function to work and the content-type header needs to be in your responses for your assets to load properly in web browsers. If you can include a change to the test suite that validates this change we can reconsider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error:
mime.lookup is not a functionSolution: Function is checked before use. No difference in functionality but fixes critical error for some dependent modules.
I do not know why
mime.lookupis undefined, but this has stopped me from using other packages that are dependent on send and has required me to continuously change this piece of code each time to be able to build my project. I would be grateful if this was merged and included in the next release.