Add type definition #109
Closed
Add type definition #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilikejames
force-pushed
the
add-type-definition
branch
from
0eec99e to
1df0908
Compare
ilikejames
force-pushed
the
add-type-definition
branch
from
1df0908 to
45aa395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few years ago I had a quick attempt at adding types for this library. https://github.com/pillarjs/router/pull/76.
This looks over the http methods exposed from the
methodslibrary and exposes these as lowercase methods on theRouterreturn object e.g.new Router().connect()This does mean that
@types/methodshas to be added as adependency, but it means only the single package will need to be updated asmethodsitself is updated.I took some inspiration from PR-100 for the build steps.