Support shared libraries #407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently returns a photo album for each shared library. This can then be
used to iterate over all the photos in that library. For example:
for library_name, album in api.photos.libraries.items():
print(f'Library: {library_name}')
for photo in album:
print(f'{photo.asset_date} {photo} {photo.filename}')
The libraries are now returned as a new object type (PhotoLibrary). That provides access to albums. This way the icloud-photos-downloader can also use the Recently Deleted special album to sync deletions. The list of non-special albums is currently returned empty for the shared libraries. This also tracks with the fact that the iCloud web app currently doesn't provide access to albums in shared libraries.
2 tasks
|
If I use this PR, the albums dict does not contain anything besides the standard folders. I can see that _fetch_folders does not return anything. Is this only my problem or a general one? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports the new iCloud shared libraries.
Example usage: