Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making drive work properly #385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fivestones
Copy link

@fivestones fivestones commented Jun 26, 2022

Proposed change

This is based on a previous PR (https://github.com/picklepete/pyicloud/pull/343/files) but done on the current drive.py main branch file. Hopefully it can be merged!

Without this PR, I can't actually see any of the files or sub-directories in any directory belonging to any apps (e.g., a 'Logseq' directory used by the Logseq iPhone app).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New service (thank you!)
  • New feature (which adds functionality to an existing service)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation or code sample

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated to README

This is based on a previous PR (https://github.com/picklepete/pyicloud/pull/343/files) but done on the current drive.py main branch file. Hopefully it can be merged!

Without this PR, I can't actually see any of the files or sub-directories in any directory belonging to any apps (e.g., a 'Logseq' directory used by the Logseq iPhone app).
@fivestones
Copy link
Author

Are there any maintainers still working on this project?

@RichieB2B
Copy link
Contributor

Looks good to me. This PR extends the api.drive beyond iCloud Drive Documents to include all iCloud enabled apps. Hopefully @balloob can merge it.

@fivestones
Copy link
Author

@balloob any chance of a merge for this?

@RichieB2B
Copy link
Contributor

@balloob Can you merge this? Or are you willing to give some one else write access to this repo?

@rustanacexd
Copy link

Should merge this btw. Fixed my issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants