Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libnettle to recently relesed 3.10.1 #101

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jan 1, 2025

What does this implement/fix?

Somehow we missed to update to 3.10 in between. The changelog is rather long and there is nothing outstanding for us, most work seems to have gone into the testing suite, e.g., related to side-channel testing in the ECC code.

Highlights from the CHANGELOG:

  • Don't reorder the subkeys during aes_invert
  • Optimize powerpc64 aes decrypt. Speedup of 80%-100%, depending on key size, when benchmarked on Power 10
  • Fix CPU feature detection on Apple M1
  • RSA-OAEP support
  • Support elf_aux_info (OpenBSD and FreeBSD)

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER added dependencies Pull requests that update a dependency file ftl-build labels Jan 1, 2025
@DL6ER DL6ER requested a review from a team January 1, 2025 18:24
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test is failing, but outside of code affected by this PR

@DL6ER
Copy link
Member Author

DL6ER commented Jan 1, 2025

Yes, I have already seen it. It is a rather often happening issue with GHA-hosted runners. On the FTL repo we don't see it very often due to the three automatic action retries but we don't have something like this here. I can only restart the failing test once all running ones are finished.

@DL6ER DL6ER merged commit f3e3eec into master Jan 2, 2025
14 checks passed
@DL6ER DL6ER deleted the ftl-build/update-nettle branch January 2, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ftl-build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants