Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Documentation fixes #2086

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

Conversation

irsheep
Copy link

@irsheep irsheep commented Oct 16, 2024

What does this PR aim to accomplish?:

Fix some typos in the API documentation and add a new section

How does this PR accomplish the above?:

Fixed an incorrect description in the "until" parameter, it was using the same description as "from"
Fixed capitalization of "Pi-hole configuration", which was creating 2 sections in API documentation, "Pi-hole Configuration" and "Pi-hole configuration"
Added a section for "Local DNS Records" with examples how to add and remove "A" and "CNAME" records.
Removed "$ref: 'common.yaml#/components/schemas/took'" from requestBody

Link documentation PRs if any are needed to support this PR:

N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Added a section for "Local DNS Records" in API documentation
Fixed capitalisation of Pi-hole configuration, which was creating 2 sections in API documentation
Amended incorrect description of the until common parameter

Signed-off-by: Luis Tavares <[email protected]>
src/api/docs/content/specs/queries.yaml Outdated Show resolved Hide resolved
src/api/docs/docs.h Dismissed Show resolved Hide resolved
@DL6ER DL6ER dismissed rdwebdesign’s stale review October 18, 2024 12:11

Has been addressed

Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission. The spell check found a small glitch, see below.

To be honest, I am not sure how I feel about adding dedicated documentation for local DNS records where /config is already documented. Yes, I see how you are getting here (making it more obvious) but one might then come and ask why we are doing it for local DNS records and local CNAMEs but not for other array-like settings (e.g., DNS upstream servers) where the same PUT/DELETE can be used.

Also, there is some glitch when you leave the field empty, you get the full config instead:
Screenshot

src/api/docs/content/specs/localdns.yaml Outdated Show resolved Hide resolved
src/api/docs/content/specs/localdns.yaml Outdated Show resolved Hide resolved
irsheep and others added 2 commits October 20, 2024 12:12
Co-authored-by: Dominik <[email protected]>
Signed-off-by: Luis Tavares <[email protected]>
You're correct authentication is required, must be a leftover when I copied from another section

Co-authored-by: Dominik <[email protected]>
Signed-off-by: Luis Tavares <[email protected]>
@irsheep
Copy link
Author

irsheep commented Oct 20, 2024

Thank you for your submission. The spell check found a small glitch, see below.

To be honest, I am not sure how I feel about adding dedicated documentation for local DNS records where /config is already documented. Yes, I see how you are getting here (making it more obvious) but one might then come and ask why we are doing it for local DNS records and local CNAMEs but not for other array-like settings (e.g., DNS upstream servers) where the same PUT/DELETE can be used.

Also, there is some glitch when you leave the field empty, you get the full config instead: Screenshot

Sorry didn't intended to close your comment without addressing this.

When I was implementing this change I thought about the same, but decided to propose it anyway for a couple of reasons

  • In the previous version of Pi-hole A and CNAME records had their own API (and only realized that this is part of /config after it was almost done)
  • The path to update or delete the DNS records requires 4 elements in the path /config/dns/_type_/_record_ , but that is not clear in the Pi-hole configuration section
  • to document that format when specifying the record. An A record uses a space "IP fqdn" and CNAME uses a comma. At first I was thinking that it was a mistake, but then realized that this is because how it written to the hosts and dnsmask files.

This one might be cheeky because just found now, the same could be said with DNS control

As for the glitch that is because as you mention proposed Local DNS records section part of the /config so by leaving the type blank in that request you're in fact requesting /config/dns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants