Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(viewer): Unneeded manual internal link; Fix target is in LaTeX #215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yhx-12243
Copy link
Contributor

Svelte has automatically internal link mechanism, so the manual implementation is not necessary and it is also wrong: When user click internal link just in LaTeX, it will goto undefined. So we simply delete it and it works well.

link.addEventListener('click', e => {
e.preventDefault()
goto((e.target as HTMLAnchorElement).href)
})

e.target is not necessary an <a>, it may deep inside a KaTeX node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant