-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove peakdet CLI and scripts #45
base: master
Are you sure you want to change the base?
Conversation
This is ready for review (but also very simple)! @physiopy/peakdet |
Previous comment was outdated, that's my bad. LGTM! |
Good catch @62442katieb ! You were right - now it's fixed. Also, since I'm already butchering the poor creature here, what do you, @tsalo, and @physiopy/phys2denoise think about the functions and classes in |
At first glance, I think the code could be very useful in |
Yes to |
I genuinely don't know. In any case, I'll remove them - they're going to be in history. |
(No, generally HRV metrics are used in analysis, not processing / denoising. I'd say it's safe to remove them if you're focusing the module on just processing 👍) |
Ah, thank you @rmarkello! |
There probably should be a place within the physiopy umbrella for calculating metrics for analysis rather than denoising, right? Do we have a planned place for things like that? |
If the analysis is MRI related, then phys2denoise would be the place for it (at least for the moment). If it's physiological signals only, probably other libraries would be more indicated (e.g. NeuroKit). |
Yes, HRV has only been proposed for analysis, not denoising. |
Under @rmarkello's suggestions in #39, this PR removes the cli module from peakdet, as well as the script folder and the two dependencies related to them (
Gooey
andwxpython
).It depends on #39 - can't be merged before that PR.