Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain the effect of current job on monitoring #237

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

kylewillmon
Copy link
Contributor

The current job concept is explained directly on the continuous monitoring page since this is where the impact is most clearly seen.

This PR should be the final change needed for the default label story

@kylewillmon kylewillmon requested a review from a team as a code owner November 21, 2024 15:56
The current job concept is explained directly on the continuous
monitoring page since this is where the impact is most clearly seen.
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small grammar change needed, plus a couple of suggestions.

docs/knowledge_base/continuous_monitoring.md Outdated Show resolved Hide resolved
docs/knowledge_base/continuous_monitoring.md Outdated Show resolved Hide resolved
@maxrake
Copy link
Contributor

maxrake commented Nov 21, 2024

It might be worth mentioning how the default label can only be set by (project/group/org?) admins. I can imagine someone without the necessary permissions reading this document, looking at the Phylum UI, and wondering why they don't see any way to change/set the default label.

@kylewillmon
Copy link
Contributor Author

kylewillmon commented Nov 21, 2024

It might be worth mentioning how the default label can only be set by (project/group/org?) admins.

The operation only requires member access.

I believe you have found a UI bug since the button to set the default label is only shown to admins. CLI correctly allows the operation for group/org members.

@kylewillmon kylewillmon requested a review from maxrake November 21, 2024 19:39
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kylewillmon kylewillmon enabled auto-merge (squash) November 21, 2024 20:21
@kylewillmon kylewillmon merged commit 4c52206 into main Nov 21, 2024
2 checks passed
@kylewillmon kylewillmon deleted the cm-default-job branch November 21, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants