-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain the effect of current job on monitoring #237
Conversation
The current job concept is explained directly on the continuous monitoring page since this is where the impact is most clearly seen.
cc28089
to
969d3f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small grammar change needed, plus a couple of suggestions.
It might be worth mentioning how the default label can only be set by (project/group/org?) admins. I can imagine someone without the necessary permissions reading this document, looking at the Phylum UI, and wondering why they don't see any way to change/set the default label. |
The operation only requires member access. I believe you have found a UI bug since the button to set the default label is only shown to admins. CLI correctly allows the operation for group/org members. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The current job concept is explained directly on the continuous monitoring page since this is where the impact is most clearly seen.
This PR should be the final change needed for the default label story