Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Maven repository proxy documentation #217

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Add Maven repository proxy documentation #217

merged 2 commits into from
Oct 29, 2024

Conversation

cd-work
Copy link
Contributor

@cd-work cd-work commented Oct 4, 2024 •
edited
Loading

Draft until we can get prod issues with Maven sorted.

@cd-work cd-work self-assigned this Oct 4, 2024
@cd-work cd-work marked this pull request as ready for review October 29, 2024 17:33
@cd-work cd-work requested a review from a team as a code owner October 29, 2024 17:33
maxrake
maxrake previously approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes were reviewed and confirmed with a local checkout and build. There is a small suggestion for removing a hard-tab character, but otherwise LGTM.

docs/artifact_repositories/maven.md Outdated Show resolved Hide resolved
@cd-work cd-work requested a review from maxrake October 29, 2024 20:50
@cd-work cd-work enabled auto-merge (squash) October 29, 2024 20:51
maxrake
maxrake approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cd-work cd-work merged commit 42016b9 into main Oct 29, 2024
2 checks passed
@cd-work cd-work deleted the aviary_maven branch October 29, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrake maxrake maxrake approved these changes

@kylewillmon kylewillmon Awaiting requested review from kylewillmon kylewillmon is a code owner automatically assigned from phylum-dev/engineering

@joephylum joephylum Awaiting requested review from joephylum joephylum is a code owner automatically assigned from phylum-dev/engineering

Assignees

@cd-work cd-work

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cd-work @maxrake