Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use relative paths when project root is set #1172

Merged
merged 11 commits into from
Aug 8, 2023
Merged

Use relative paths when project root is set #1172

merged 11 commits into from
Aug 8, 2023

Conversation

ejortega
Copy link
Contributor

@ejortega ejortega commented Aug 4, 2023

The lockfile paths were being submitted with an absolute path if the project root was set.

This can be caused by using relative lockfile paths in in the .phylum_project.

Closes #1169

Checklist

  • Does this PR have an associated issue (i.e., closes #<issueNum> in description above)?
  • Have you ensured that you have met the expected acceptance criteria?
  • Have you created sufficient tests?
  • Have you updated all affected documentation?
  • Have you updated CHANGELOG.md (or extensions/CHANGELOG.md), if applicable

@ejortega ejortega requested a review from a team as a code owner August 4, 2023 05:24
cd-work
cd-work requested changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@cd-work cd-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also strip prefixes from absolute paths to avoid storing host and user names.

cd-work
cd-work reviewed Aug 4, 2023
View reviewed changes
cli/src/commands/parse.rs Outdated Show resolved Hide resolved
cd-work
cd-work requested changes Aug 7, 2023
View reviewed changes
cli/src/commands/parse.rs Outdated Show resolved Hide resolved
cli/src/commands/parse.rs Outdated Show resolved Hide resolved
@ejortega ejortega requested a review from cd-work August 8, 2023 00:40
@ejortega ejortega mentioned this pull request Aug 8, 2023
Merged
4 tasks
kylewillmon
kylewillmon requested changes Aug 8, 2023
View reviewed changes
cli/src/commands/parse.rs Outdated Show resolved Hide resolved
cli/src/commands/parse.rs Outdated Show resolved Hide resolved
cli/src/commands/parse.rs Outdated Show resolved Hide resolved
cli/src/commands/parse.rs Outdated Show resolved Hide resolved
cli/src/commands/parse.rs Outdated Show resolved Hide resolved
cli/src/commands/parse.rs Outdated Show resolved Hide resolved
cli/src/commands/parse.rs Outdated Show resolved Hide resolved
cli/src/commands/parse.rs Outdated Show resolved Hide resolved
kylewillmon
kylewillmon requested changes Aug 8, 2023
View reviewed changes
cli/tests/parse.rs Outdated Show resolved Hide resolved
kylewillmon
kylewillmon reviewed Aug 8, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
kylewillmon
kylewillmon reviewed Aug 8, 2023
View reviewed changes
cli/tests/parse.rs Outdated Show resolved Hide resolved
kylewillmon
kylewillmon previously approved these changes Aug 8, 2023
View reviewed changes
@ejortega @kylewillmon
Update CHANGELOG.md
f1d9487 
Co-authored-by: Kyle Willmon <[email protected]>
@ejortega ejortega merged commit 0e6b53c into main Aug 8, 2023
13 checks passed
@ejortega ejortega deleted the use_relative_paths branch August 8, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cd-work cd-work cd-work approved these changes

@kylewillmon kylewillmon kylewillmon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lockfile paths should be relative
3 participants
@ejortega @kylewillmon @cd-work