New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for boolean in while conditions #260

Open

VincentLanglet wants to merge 1 commit into phpstan:2.0.x from VincentLanglet:whileCondition

Contributor

VincentLanglet commented Jan 22, 2025

Might be enough to close #259

I tried to implement the same thing for For_.

But the issue I encounter in

for ($i = 0; $i; $i++) {}

is that $i is considered as a MixedType, which is non explicit, so BooleanHelper::passesAsBoolean always return true.

So i'm unsure the rule is doable for for loops.


          Check for boolean in while conditions

81e96e5

VincentLanglet force-pushed the whileCondition branch from a48f7f2 to 81e96e5 Compare

January 23, 2025 00:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet